Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and modernize dispatch codegen #933

Merged
merged 7 commits into from
Sep 21, 2021

Conversation

Robbepop
Copy link
Collaborator

@Robbepop Robbepop commented Sep 21, 2021

Work carved out of #665.

  • Improves macro hygiene of dispatch codegen.
  • Modernizes generated selector namespaces of ink! messages and ink! constructors.
    • Uses const generic parameters instead of abusing array lengths.
  • Improves panic messages for debugging dispatching.
  • Uses big-letter hex-encoded IDs for generated message and constructor info types.

@codecov-commenter
Copy link

Codecov Report

Merging #933 (8bb7d68) into master (41b0a1c) will increase coverage by 2.95%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   84.20%   87.15%   +2.95%     
==========================================
  Files         173      169       -4     
  Lines        7939     7561     -378     
==========================================
- Hits         6685     6590      -95     
+ Misses       1254      971     -283     
Impacted Files Coverage Δ
crates/lang/ir/src/ir/selector.rs 75.00% <66.66%> (-10.72%) ⬇️
crates/lang/codegen/src/generator/dispatch.rs 99.42% <90.90%> (-0.58%) ⬇️
crates/env/src/engine/off_chain/db/chain_spec.rs 79.54% <0.00%> (-20.46%) ⬇️
crates/env/src/engine/off_chain/chain_extension.rs 57.14% <0.00%> (-7.86%) ⬇️
crates/env/src/engine/off_chain/db/events.rs 93.54% <0.00%> (-6.46%) ⬇️
crates/env/src/engine/off_chain/db/accounts.rs 81.15% <0.00%> (-5.43%) ⬇️
crates/env/src/engine/off_chain/mod.rs 86.95% <0.00%> (-2.66%) ⬇️
crates/metadata/src/lib.rs 0.00% <0.00%> (ø)
crates/primitives/src/key_ptr.rs 100.00% <0.00%> (ø)
crates/env/src/backend.rs
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41b0a1c...8bb7d68. Read the comment docs.

@Robbepop Robbepop merged commit 0270add into master Sep 21, 2021
@Robbepop Robbepop deleted the robin-refactor-dispatch-codegen branch September 21, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants