Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support disable change username and nickname #3911

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

thezzisu
Copy link
Contributor

When using Single Sign-On (SSO) for a restricted environment (eg. in colleges or institutions), username and nickname should be set to SSO-provided value and users should not be able to edit them.

This PR implements this functionality by adding two workspace settings.

image

@thezzisu thezzisu requested a review from boojack as a code owner September 11, 2024 05:23
Copy link
Contributor

@RoccoSmit RoccoSmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some form of UI visualization showing that the values can't be changed. e.g. showing label or disabled text inputs instead of text input.

Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@boojack boojack merged commit b787d1c into usememos:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants