Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing german translations #4268

Merged
merged 1 commit into from
Jan 4, 2025
Merged

add missing german translations #4268

merged 1 commit into from
Jan 4, 2025

Conversation

tungerno
Copy link
Contributor

@tungerno tungerno commented Jan 3, 2025

  • Add missing translated keys with corresponding German translations.
  • See also issue [BUG] Missing german (de) translations [BUG] Missing german (de) translations #4267
  • remove unused keys (compare to en.json file)
    I assumed that the English local file is the leading one and that keys that are not listed here are obsolete and can be deleted.

@tungerno tungerno marked this pull request as ready for review January 4, 2025 00:13
@tungerno tungerno requested a review from boojack as a code owner January 4, 2025 00:13
RoccoSmit
RoccoSmit approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@RoccoSmit RoccoSmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyjoygh johnnyjoygh merged commit e3d1967 into usememos:main Jan 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoccoSmit RoccoSmit RoccoSmit approved these changes

@boojack boojack Awaiting requested review from boojack boojack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tungerno @RoccoSmit @johnnyjoygh