Minor updates related to documentation for commands and more osnadmin…

… updates (release-2.3) (hyperledger#2322)

* Avoid os.Exit behavior when an osnadmin test fails

This change returns an error from `executeForArgs` when the command line
cannot be parsed. Without this change, tests that use the function
quietly exit without a clear indication as to why.

Signed-off-by: Matthew Sykes <[email protected]>

* generateHelpDocs filters trailing space from text

- Change the generateHelpDocs script to remove trailing spaces from the
  generated help text. This prevents linting failures from
  check_trailingspaces.sh
- Remove trailing space from osnadmin_channel_postscript.md
- Regenerate the help docs with `make help-docs`

Signed-off-by: Matthew Sykes <[email protected]>

* Fix channelID flag reference in osnadmin help

Signed-off-by: Matthew Sykes <[email protected]>

cmd/osnadmin/main_test.go

@@ -582,6 +582,18 @@ var _ = Describe("osnadmin", func() {
 			})
 		})
 
+		Context("when an unknown flag is used", func() {
+			It("returns an error for long flags", func() {
+				_, _, err := executeForArgs([]string{"channel", "list", "--bad-flag"})
+				Expect(err).To(MatchError("unknown long flag '--bad-flag'"))
+			})
+
+			It("returns an error for short flags", func() {
+				_, _, err := executeForArgs([]string{"channel", "list", "-z"})
+				Expect(err).To(MatchError("unknown short flag '-z'"))
+			})
+		})
+
 		Context("when the ca cert cannot be read", func() {
 			BeforeEach(func() {
 				ordererCACert = "not-the-ca-cert-youre-looking-for"