Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce environment_variable_groups to the vh exec run command #323

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kenneth-Schroeder
Copy link
Contributor

@Kenneth-Schroeder Kenneth-Schroeder commented Feb 10, 2025

I want to make the environment_variable_groups setting accessible from the CLI and from the valohai yaml.
To achieve this, I have created a PR in valohai-yaml as well (valohai-yaml#160).

I could test my changes on valohai-cli and the local linting on valohai-yaml, however, the API endpoint seems to validate with an older valohai-yaml version as well, causing an API validation error for the yaml version.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (02d2801) to head (c0a0146).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   86.17%   86.18%           
=======================================
  Files         129      129           
  Lines        4607     4610    +3     
  Branches      592      592           
=======================================
+ Hits         3970     3973    +3     
  Misses        446      446           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tokkoro tokkoro requested a review from akx February 12, 2025 09:39
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, there's a difference between explicitly passing "environment_variable_groups": [] and not passing it at all to the API.

If you don't pass it at all, the defaults from the project are used; if you explicitly pass an empty list, the defaults are not used.

Eyeballing this, one of those scenarios isn't supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants