Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate for scan-part2 #136

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Authenticate for scan-part2 #136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e4138f
fix auth for scan
caton-hpg Apr 26, 2024
348bc7c
fix StorageClient
caton-hpg Apr 26, 2024
4d901ab
default value for user and password
caton-hpg Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/nebula/sclient/StorageClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class StorageClient {
std::string filter = "",
bool onlyLatestVersion = false,
bool enableReadFromFollower = true,
bool needAuth = false,
const std::string& username = "",
const std::string& password = "");

Expand All @@ -96,7 +95,6 @@ class StorageClient {
std::string filter = "",
bool onlyLatestVersion = false,
bool enableReadFromFollower = true,
bool needAuth = false,
const std::string& username = "",
const std::string& password = "");

Expand Down
6 changes: 2 additions & 4 deletions src/sclient/StorageClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ ScanEdgeIter StorageClient::scanEdgeWithPart(std::string spaceName,
std::string filter,
bool onlyLatestVersion,
bool enableReadFromFollower,
bool needAuth,
const std::string& username,
const std::string& password) {
auto spaceIdResult = mClient_->getSpaceIdByNameFromCache(spaceName);
Expand Down Expand Up @@ -84,7 +83,7 @@ ScanEdgeIter StorageClient::scanEdgeWithPart(std::string spaceName,
req->set_filter(filter);
req->set_only_latest_version(onlyLatestVersion);
req->set_enable_read_from_follower(enableReadFromFollower);
req->set_need_authenticate(needAuth);
req->set_need_authenticate(true);
req->set_username(username);
req->set_password(password);

Expand Down Expand Up @@ -125,7 +124,6 @@ ScanVertexIter StorageClient::scanVertexWithPart(
std::string filter,
bool onlyLatestVersion,
bool enableReadFromFollower,
bool needAuth,
const std::string& username,
const std::string& password) {
auto spaceIdResult = mClient_->getSpaceIdByNameFromCache(spaceName);
Expand Down Expand Up @@ -164,7 +162,7 @@ ScanVertexIter StorageClient::scanVertexWithPart(
req->set_filter(filter);
req->set_only_latest_version(onlyLatestVersion);
req->set_enable_read_from_follower(enableReadFromFollower);
req->set_need_authenticate(needAuth);
req->set_need_authenticate(true);
req->set_username(username);
req->set_password(password);

Expand Down
Loading