Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed my version of #162 fix #169

Closed
wants to merge 4 commits into from
Closed

Conversation

Yardie-
Copy link
Contributor

@Yardie- Yardie- commented Mar 13, 2022

I think I did this correctly.

Yardie- added 4 commits March 2, 2022 12:29
This returns a rectangle with the height and width adjusted. Also allows margins
This is just a hack but ended up in here.
@Yardie- Yardie- closed this Mar 13, 2022
@Yardie-
Copy link
Contributor Author

Yardie- commented Mar 13, 2022

Sorry that was the wrong way to do it clearly.

@martinberlin
Copy link
Collaborator

@Yardie- you can try #168
That hopefully will be a new way to add custom boards and this Lilygo oddity fits much better there

@Yardie-
Copy link
Contributor Author

Yardie- commented Mar 13, 2022

Thanks Yes @martinberlin I was trying to get my hack out of my pull request.
I will test this when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants