add epd_powerdown for lilygo #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On lilygo disable display power but not touch screen. The epd power flag was re-purposed as power enable however it also disables the touch. this workaround may still leave power on to epd and as such may cause other problems such as grey screen. please also use poweroff when you sleep the system wake on touch will still work just not the I2C interface.
martinberlin
approved these changes
May 9, 2022
|
Thanks @martinberlin I'm not sure how to deal with the documentation side of this. |
|
Just add a small addition in the Readme please mentioning what is the use-case for this function. |
|
Thanks @martinberlin. |
Sorry it's not the prettiest thing.
|
Ok that's done. Sorry I had to do it by hand and don't know markdown, |
Deoxygenised the comments on the function so it will be explained in the readthedocs.io
martinberlin
previously requested changes
May 10, 2022
jdoubleu
reviewed
May 10, 2022
|
This merge in a single commit: fd8a290 was reversed since it added a function cfg_powerdown is a exact copy of existing funcion cfg_poweroff CC @mickeprag |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lilygo specific function that did my head in for a while.
When the power is turned off to the epd it seems the power to the touch screen is also disabled. Below are the notes I added.
On lilygo disable display power but not touch screen.
The epd power flag was re-purposed as power enable
however it also disables the touch.
this workaround may still leave power on to epd
and as such may cause other problems such as grey screen.
please also use poweroff when you sleep the system
wake on touch will still work just not the I2C interface.