Align dma buffers #248
Merged
Align dma buffers #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the TPS65185 are unable to start the PWRGOOD signal will never assert.
The size of the buffers used by DMA must be word aligned. If the width of the screen is not aligned we increase the buffer slightly.
|
Looks good to me, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the buffers used by DMA must be word aligned. If the width of the display is not aligned we increase the buffer slightly.
For instance the display ED060KC1 has a width of 1448 pixels. The DMA buffer would be 362 bytes (1448/4) and this will not work with the ESP32 DMA driver. Instead the buffer will be increased to 364 bytes.
Also a small fix for faulty boards which made the power on code loop forever.