Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection jumper 5v/3v, also gnd planes #6

Merged
merged 3 commits into from
May 28, 2020
Merged

Conversation

sebastius
Copy link
Contributor

This should solve #3 by making the voltage to the LT1945 selectable (default at 5v).

Redid some ground traces and planes for better ground coverage.

@vroland
Copy link
Owner

vroland commented May 28, 2020

Looks good so far, thanks for contributing :)
However, my KiCad (5.1.6) complains about some via clearances (with its default settings, 0.25mm maybe?):
clearances
Could you look into it?

@sebastius
Copy link
Contributor Author

Should be fine: JLC has the following minimum: 5mil (0.127mm)

@vroland
Copy link
Owner

vroland commented May 28, 2020

Do you know if that's true for other manufacturers as well? I mean, we should not constrain us here unnecessarily. It seems most of them only need a little wiggle, so I could do it as well.

@sebastius
Copy link
Contributor Author

sebastius commented May 28, 2020

Feel free to wiggle :) (although most pcb manufacturers are perfectly capable of this):

PCBway: Min manufacturable spacing is 4mil(0.1mm), strongly suggest to design spacing above 6mil(0.15mm) to save cost.

JLC is at 5mil

Dirtypcbs is at 6mil

OSHpark is at 6 mil

Suggest you set it at 10mil in Kicad (also in the gndplanes etc)

@vroland
Copy link
Owner

vroland commented May 28, 2020

Could you rebase this to remove fd648a7 and 95a5599?

@vroland
Copy link
Owner

vroland commented May 28, 2020

Aand quickly rebase onto the current master? :)

@sebastius
Copy link
Contributor Author

I think i've done it, a friend helped me by telling me what to do ;)

@vroland vroland merged commit 902249f into vroland:master May 28, 2020
@vroland
Copy link
Owner

vroland commented May 29, 2020

@sebastius Is there a specific reason you got rid of the mounting holes? I think it would be nice to have them, though I would be open to moving them to different locations.

@sebastius
Copy link
Contributor Author

I didn't remove the mounting holes on purpose, sorry! They should be there, if i removed them, we'll need to look into bringing them back, or reverting and redoing my mods. Which do you prefer?

@vroland
Copy link
Owner

vroland commented May 29, 2020

Ah, probably because they where not in the schematic, to KiCad removed them when updating the PCB. So I would re-add them and move them to their old positions.
Do you want to do it (and re-position the ground vias) or shoud I do it at some time?

@sebastius
Copy link
Contributor Author

sebastius commented May 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants