-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more detail about SKIP_EMAIL_VERIFICATION_IN_DEV to e2e tests README #373
base: main
Are you sure you want to change the base?
Conversation
Fixes wasp-lang#363 Add `SKIP_EMAIL_VERIFICATION_IN_DEV=true` to `template/app/.env.server.example` file. * Add a new section to the file to skip email verification in development mode. * Add `SKIP_EMAIL_VERIFICATION_IN_DEV=true` to the new section.
Hey @pshycodr we actually would like to allow the user to decide for themselves if they want to skip email verification in development. Is there a reason you think it should be in there by default (if that reason is e2e tests, then you'll see we instruct the user to add it before running them in the e2e-tests README file). |
@vincanger |
but we have an explicit mention of it in the
If we add this to the app by default, then users may not understand that the auth method sends an email verification link by default. They also won't be able to test their customize verification email they'd like to send. I think it's best we leave it as is. |
Hey @vincanger,
|
Update README with SKIP_EMAIL_VERIFICATION_IN_DEV instructions and remove default from .env
Added more detailed explanations about the SKIP_EMAIL_VERIFICATION_IN_DEV variable in e2e-tests/README.md, including its significance, usage in CI pipelines, and troubleshooting tips. Let me know if any additional clarifications are needed!
@vincanger |
Fixes #363
Add
SKIP_EMAIL_VERIFICATION_IN_DEV=true
totemplate/app/.env.server.example
file.SKIP_EMAIL_VERIFICATION_IN_DEV=true
to the new section.