Improve gif quality by appropriately sizing gifs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code resized gifs down to 320x240 which twitter then scaled back up to 528x396 resulting in grainy gifs. This change r It also tells gifsicle to limit gif colors to 256 which should reduce file size.
|
While I think this will help with overall quality and size, I suspect you'd get much better results by posting an reasonably sized mp4 to twitter (as a video). You'd be able to achieve much higher video quality and stay well below the twitter video size limit. |
|
Thanks for this, really appreciate the contribution here. Let me test this first. I also tweet the link to the mp4. Twitter doesn't let you upload a mp4 unfortunately. The only solution is to have my own player but they would first need to approve it. |
|
Works great, merging! Thanks again! |
xdamman
added a commit
that referenced
this pull request
Jun 25, 2014
Improve gif quality by appropriately sizing gifs
|
Or reverse the Vine/Instagram API? 0:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code resized gifs down to 320x240 which twitter then scaled back up to 528x396 resulting in grainy gifs. This change r
It also tells gifsicle to limit gif colors to 256 which should reduce file size.
NOTE: This code should be tested to ensure that it generates gifs below the 3MB Twitter limit.