Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forc IPFS package fetching capabilities does not work with Pinata pinned packages #6721

Closed
kayagokalp opened this issue Nov 13, 2024 · 0 comments · Fixed by #6902
Closed

Forc IPFS package fetching capabilities does not work with Pinata pinned packages #6721

kayagokalp opened this issue Nov 13, 2024 · 0 comments · Fixed by #6902
Assignees
@kayagokalp
Labels
bug Something isn't working

Comments

@kayagokalp
Copy link
Member

Problem

We cannot use forc to fetch packages pinned by pinata. Pinata is a widely used pinning service making this limitation an important blocker in terms of reaching a working package registry and reduces the overall usability of IPFS support forc-pkg currently offers.

We are also planning to use pinata for package registry to make things a little bit easier. So it is for best if we solve this before going forward.
@kayagokalp kayagokalp added bug Something isn't working forc-pkg Everything related to the `forc-pkg` crate. labels Nov 13, 2024
@linear linear bot added Migrated and removed forc-pkg Everything related to the `forc-pkg` crate. Migrated labels Jan 29, 2025
@kayagokalp kayagokalp mentioned this issue Feb 7, 2025
Merged
sdankel pushed a commit that referenced this issue Feb 11, 2025
@kayagokalp @sdankel
fix: remove invalid unpacking logic for IPFS pinned pkg sources (#6902)
ab2151d 
## Description
closes #6721.

There were couple of issues:

1. Archive unpacking was getting the bytes from `text` field of response
to the IPFS gateway which was adding additional stuff that messes with
unpacking routine.
2. Folder name was invalid so forc was unable to find the packages in
the `ipfs` cache.

Both issues are addressed and this unblocks forc to fetch ipfs fetched
packages once again. Next up on our package registry push is to enable
alternative sources and set the precedence for them.

Also added some tests around extracting logic, which inserts the
contents under a directory named after `CID` as this is how `forc` is
looking for these sources in the first place (related to point 2 above)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayagokalp kayagokalp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove invalid unpacking logic for IPFS pinned pkg sources FuelLabs/sway
1 participant
@kayagokalp