fix: remove invalid unpacking logic for IPFS pinned pkg sources #6902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
forc-pkg
kayagokalp
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #6902 will not alter performanceComparing Summary
|
zees-dev
reviewed
Feb 9, 2025
zees-dev
previously approved these changes
Feb 9, 2025
kayagokalp
dismissed stale reviews from zees-dev and JoshuaBatty
via
5cc8325
kayagokalp
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
kayagokalp
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
kayagokalp
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
JoshuaBatty
approved these changes
Feb 11, 2025
sdankel
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Description closes #6721. There were couple of issues: 1. Archive unpacking was getting the bytes from `text` field of response to the IPFS gateway which was adding additional stuff that messes with unpacking routine. 2. Folder name was invalid so forc was unable to find the packages in the `ipfs` cache. Both issues are addressed and this unblocks forc to fetch ipfs fetched packages once again. Next up on our package registry push is to enable alternative sources and set the precedence for them. Also added some tests around extracting logic, which inserts the contents under a directory named after `CID` as this is how `forc` is looking for these sources in the first place (related to point 2 above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6721.
There were couple of issues:
textfield of response to the IPFS gateway which was adding additional stuff that messes with unpacking routine.ipfscache.Both issues are addressed and this unblocks forc to fetch ipfs fetched packages once again. Next up on our package registry push is to enable alternative sources and set the precedence for them.
Also added some tests around extracting logic, which inserts the contents under a directory named after
CIDas this is howforcis looking for these sources in the first place (related to point 2 above)