-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add debug UI options for new GS dumping options. #12302
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HW and SW dump directories seem inverted?
When Dump GS Draws is unchecked all other options should grey out.
Draw dumping seems inconsistent, sometimes they dump, sometimes not.
For me it seems to only dump if you switch between renderers.
Couldn't reproduce any inconsistency. Was just about to mention the other things. |
cd7bee6
to
be4722f
Compare
Thanks for points out the issues @lightningterror and @F0bes. Fixed the HW/SW directories being swapped and the expected graying out when we disable Dump GS Data. I could not reproduce the inconsistency either. One gotcha that may cause the issue is that the intersection of draw number range and frames number range is used, so if they do not overlap, then nothing will be dumped. |
@lightningterror I think there is a good chance that wouldn't dump anything because the frame number and draw number both start from 0, so as long as the 0th frame took 21 or more draws nothing would be dumped. Would it be better for the UI to expect draw/frame numbers to be 0-based? |
b7e23f4
to
7b5081e
Compare
I think it being 0 based is fine. |
@F0bes Ok, I'll leave it as is then |
Description of Changes
Add UI elements for options to control dumping of GS data in the System/Settings/Debug/GS menu. Specifically: SaveInfo, SaveAlpha, Start Frame Number, Frame Dump Count. Note: This is a quick (but hopefully not dirty) PR to add the missing functionality that I intend to improve in a followup PR.
Rationale behind Changes
I forgot to add these in a previous PR that added the said options.
Suggested Testing Steps
Run any game and use the options mentioned above in the menubar System/Settings/Debug/GS (after enabling advanced settings in the menubar Tools/Show Advanced Settings).