Debugger Assembler: BC1(t|f) 24 bit immediates to 16 bit immediates #12337
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes an invalid opcode form in the assembler table.
Also added an error message to an expression parser failure condition.
Rationale behind Changes
This made assembling bc1f/bc1t bc1fl/bc1tl not possible as the immediate was clobbering the bits outside of the offset field.
The error message fixes a case where entering multiple constants failed, but didn't say why.
Suggested Testing Steps
Try assembling the previously mentioned opcodes. The assembler uses absolute addressing (and internally converts it to be relative). Try assembling the maximum offset possible and beyond, make sure that there is no off-by-one errors.