-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keycloak_user_federation: fix diff of empty krbPrincipalAttribute
#8320
keycloak_user_federation: fix diff of empty krbPrincipalAttribute
#8320
Conversation
c377acc
to
d77b5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The change looks good to me. If nobody objects, I'll merge it in ~a week.
a71e191
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #8339 🤖 @patchback |
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8340 🤖 @patchback |
@yeoldegrove thanks for your contribution! |
…diff of empty `krbPrincipalAttribute` (#8339) keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320) keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320) (cherry picked from commit a71e191) Co-authored-by: Eike Waldt <[email protected]>
…diff of empty `krbPrincipalAttribute` (#8340) keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320) keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320) (cherry picked from commit a71e191) Co-authored-by: Eike Waldt <[email protected]>
…nsible-collections#8320) keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (ansible-collections#8320)
…nsible-collections#8320) keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (ansible-collections#8320)
SUMMARY
krbPrincipalAttribute
is supposed to have an empty string as a valid value.community.general/plugins/modules/keycloak_user_federation.py
Line 346 in bc609d7
Without this bugfix, an
ansible-playbook ... --check --diff
run will always show an empty string in the diff if you pass en empty string toconfig.krbPrincipalAttribute
.ISSUE TYPE
COMPONENT NAME
keycloak_user_federation