Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak_user_federation: fix diff of empty krbPrincipalAttribute #8320

Conversation

yeoldegrove
Copy link
Contributor

@yeoldegrove yeoldegrove commented May 6, 2024

SUMMARY

krbPrincipalAttribute is supposed to have an empty string as a valid value.

When this is empty, the LDAP user will be looked based on LDAP username corresponding

Without this bugfix, an ansible-playbook ... --check --diffrun will always show an empty string in the diff if you pass en empty string to config.krbPrincipalAttribute.

TASK [kc1 - realm-1 - test-2 - Create or update a Keycloak kerberos enabled user_federation] ********************************************************************************************************************************************
--- before
+++ after
@@ -17,6 +17,7 @@
         "importEnabled": "false",
         "kerberosRealm": "EXAMPLE.NET",
         "keyTab": "/mnt/ad2",
+        "krbPrincipalAttribute": "",
         "pagination": "false",
         "priority": "0",
         "rdnLDAPAttribute": "sAMAccountName",
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_user_federation

@yeoldegrove yeoldegrove force-pushed the fix/krbPrincipalAttribute_diff branch from c377acc to d77b5f0 Compare May 6, 2024 09:07
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels May 6, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels May 6, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The change looks good to me. If nobody objects, I'll merge it in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 11, 2024
@felixfontein felixfontein merged commit a71e191 into ansible-collections:main May 11, 2024
132 of 133 checks passed
Copy link

patchback bot commented May 11, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/a71e19130d041752aa393be85c22adcb1ad63e7a/pr-8320

Backported as #8339

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 11, 2024
…8320)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

(cherry picked from commit a71e191)
Copy link

patchback bot commented May 11, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/a71e19130d041752aa393be85c22adcb1ad63e7a/pr-8320

Backported as #8340

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@yeoldegrove thanks for your contribution!

patchback bot pushed a commit that referenced this pull request May 11, 2024
…8320)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

(cherry picked from commit a71e191)
felixfontein pushed a commit that referenced this pull request May 11, 2024
…diff of empty `krbPrincipalAttribute` (#8339)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

(cherry picked from commit a71e191)

Co-authored-by: Eike Waldt <[email protected]>
felixfontein pushed a commit that referenced this pull request May 11, 2024
…diff of empty `krbPrincipalAttribute` (#8340)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

(cherry picked from commit a71e191)

Co-authored-by: Eike Waldt <[email protected]>
austinlucaslake pushed a commit to austinlucaslake/community.general that referenced this pull request May 25, 2024
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants