Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8320/a71e1913 backport][stable-7] keycloak_user_federation: fix diff of empty krbPrincipalAttribute #8339

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 11, 2024

This is a backport of PR #8320 as merged into main (a71e191).

SUMMARY

krbPrincipalAttribute is supposed to have an empty string as a valid value.

When this is empty, the LDAP user will be looked based on LDAP username corresponding

Without this bugfix, an ansible-playbook ... --check --diffrun will always show an empty string in the diff if you pass en empty string to config.krbPrincipalAttribute.

TASK [kc1 - realm-1 - test-2 - Create or update a Keycloak kerberos enabled user_federation] ********************************************************************************************************************************************
--- before
+++ after
@@ -17,6 +17,7 @@
         "importEnabled": "false",
         "kerberosRealm": "EXAMPLE.NET",
         "keyTab": "/mnt/ad2",
+        "krbPrincipalAttribute": "",
         "pagination": "false",
         "priority": "0",
         "rdnLDAPAttribute": "sAMAccountName",
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_user_federation

…8320)

keycloak_user_federation: fix diff of empty `krbPrincipalAttribute` (#8320)

(cherry picked from commit a71e191)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels May 11, 2024
@felixfontein felixfontein merged commit be4e7fc into stable-7 May 11, 2024
146 of 147 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-7/a71e19130d041752aa393be85c22adcb1ad63e7a/pr-8320 branch May 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants