Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5568: CI changes to verify code format and unit test check in github action for java and kotlin #2599

Merged
merged 2 commits into from
May 7, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented May 6, 2022

add check in github action for java and kotlin, and also enable ktmftCheck for kotlin, similar to spotlessCheck

as a follow up on:

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jimexist
Copy link
Member Author

jimexist commented May 6, 2022

@ctubbsii this is a follow up so i didn't bother creating a new jira for this

@jimexist
Copy link
Member Author

jimexist commented May 6, 2022

the kotlin code changes in this pull request is done automatically using ktfmtFormat

@jimexist jimexist changed the title add check in github action for java and kotlin add code format check in github action for java and kotlin May 6, 2022
@jimexist jimexist changed the title add code format check in github action for java and kotlin add code format and unit test check in github action for java and kotlin May 6, 2022
@ctubbsii ctubbsii changed the title add code format and unit test check in github action for java and kotlin THRIFT-5568: CI changes to verify code format and unit test check in github action for java and kotlin May 6, 2022
@ctubbsii ctubbsii merged commit bcac978 into apache:master May 7, 2022
@jimexist jimexist deleted the gh-action-kt-java branch May 7, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants