Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5568: CI changes to verify code format and unit test check in github action for java and kotlin #2599

Merged
merged 2 commits into from
May 7, 2022
Merged

THRIFT-5568: CI changes to verify code format and unit test check in github action for java and kotlin #2599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984ef48
add check in github action for java and kotlin
jimexist May 6, 2022
9d2573c
Merge branch 'master' into gh-action-kt-java
ctubbsii May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: 'Build'
name: "Build"

on:
push:
branches: [ '*' ]
branches: ["*"]
pull_request:
branches: [ '*' ]
branches: ["*"]

env:
BUILD_DEPS: automake bison flex g++ git libboost-all-dev libevent-dev libssl-dev libtool make pkg-config
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
with:
distribution: temurin
java-version: 11
cache: 'gradle'
cache: "gradle"

- name: Install dependencies
run: |
Expand All @@ -77,11 +77,16 @@ jobs:
sudo ln -s /usr/local/gradle/bin/gradle /usr/local/bin
gradle --version

- name: Run spotlessCheck
- name: Run spotlessCheck for Java
run: |
cd lib/java
gradle spotlessCheck

- name: Run ktfmtCheck for Kotlin
run: |
cd lib/kotlin
gradle ktfmtCheck

- name: Run bootstrap
run: ./bootstrap.sh

Expand Down Expand Up @@ -123,8 +128,14 @@ jobs:
chmod a+x compiler/cpp/thrift
compiler/cpp/thrift -version

- name: Run make java
- name: Run make for java
run: make -C lib/java

- name: Run make kotlin
- name: Run make check for java
run: make -C lib/java check

- name: Run make for kotlin
run: make -C lib/kotlin

- name: Run make check for kotlin
run: make -C lib/kotlin check