feat: Implement remaining Navigator functionality for new header #3012

spalmurray-codecov · 2024-07-12T18:57:00Z

Adds logic for adjusting the navigator shown on different pages of the app along with actually rendering those navigators.

I'm still doing another styling pass over everything so please ignore minor styling issues for now!

Design

Screenshots

Owner page shows Context switcher for navigation:

Self-hosted admin settings uses a breadcrumb:

Repo page uses a breadcrumb:

codecov-qa · 2024-07-12T18:59:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (135fdf5) to head (e3e6a50).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3012   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         907      908    +1     
  Lines       13476    13499   +23     
  Branches     3559     3637   +78     
=======================================
+ Hits        13254    13277   +23     
  Misses        218      218           
  Partials        4        4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <ø> (ø)`
.../Header/components/Navigator/MyContextSwitcher.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`100.00% <100.00%> (ø)`
src/services/user/useMyContexts.ts	`100.00% <100.00%> (ø)`
src/services/user/useOwner.js	`100.00% <ø> (ø)`
src/services/user/useUser.ts	`100.00% <ø> (ø)`
src/ui/Breadcrumb/Breadcrumb.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <100.00%> (+0.13%)`	⬆️
Pages	`99.15% <ø> (ø)`
Services	`99.47% <100.00%> (+<0.01%)`	⬆️
Shared	`99.69% <ø> (ø)`
UI	`94.27% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...e3e6a50. Read the comment docs.

codecov-staging · 2024-07-12T18:59:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3012   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         907      908    +1     
  Lines       13476    13499   +23     
  Branches     3633     3637    +4     
=======================================
+ Hits        13254    13277   +23     
  Misses        218      218           
  Partials        4        4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <ø> (ø)`
.../Header/components/Navigator/MyContextSwitcher.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`100.00% <100.00%> (ø)`
src/services/user/useMyContexts.ts	`100.00% <100.00%> (ø)`
src/services/user/useOwner.js	`100.00% <ø> (ø)`
src/services/user/useUser.ts	`100.00% <ø> (ø)`
src/ui/Breadcrumb/Breadcrumb.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <100.00%> (+0.13%)`	⬆️
Pages	`99.15% <ø> (ø)`
Services	`99.47% <100.00%> (+<0.01%)`	⬆️
Shared	`99.69% <ø> (ø)`
UI	`94.27% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...e3e6a50. Read the comment docs.

codecov-public-qa · 2024-07-12T18:59:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (135fdf5) to head (e3e6a50).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3012   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         907      908    +1     
  Lines       13476    13499   +23     
  Branches     3607     3637   +30     
=======================================
+ Hits        13254    13277   +23     
  Misses        218      218           
  Partials        4        4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <ø> (ø)`
.../Header/components/Navigator/MyContextSwitcher.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`100.00% <100.00%> (ø)`
src/services/user/useMyContexts.ts	`100.00% <100.00%> (ø)`
src/services/user/useOwner.js	`100.00% <ø> (ø)`
src/services/user/useUser.ts	`100.00% <ø> (ø)`
src/ui/Breadcrumb/Breadcrumb.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <100.00%> (+0.13%)`	⬆️
Pages	`99.15% <ø> (ø)`
Services	`99.47% <100.00%> (+<0.01%)`	⬆️
Shared	`99.69% <ø> (ø)`
UI	`94.27% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...e3e6a50. Read the comment docs.

codecov · 2024-07-12T18:59:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (135fdf5) to head (e3e6a50).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##               main      #3012   +/-   ##
===========================================
  Coverage   98.35000   98.35000           
===========================================
  Files           907        908    +1     
  Lines         13476      13499   +23     
  Branches       3633       3642    +9     
===========================================
+ Hits          13254      13277   +23     
  Misses          218        218           
  Partials          4          4

Files	Coverage Δ
src/layouts/Header/Header.tsx	`100.00% <ø> (ø)`
.../Header/components/Navigator/MyContextSwitcher.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`100.00% <100.00%> (ø)`
src/services/user/useMyContexts.ts	`100.00% <100.00%> (ø)`
src/services/user/useOwner.js	`100.00% <ø> (ø)`
src/services/user/useUser.ts	`100.00% <ø> (ø)`
src/ui/Breadcrumb/Breadcrumb.jsx	`100.00% <100.00%> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`53.84% <ø> (ø)`
Layouts	`97.68% <100.00%> (+0.13%)`	⬆️
Pages	`99.15% <ø> (ø)`
Services	`99.47% <100.00%> (+<0.01%)`	⬆️
Shared	`99.69% <ø> (ø)`
UI	`94.27% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...e3e6a50. Read the comment docs.

codecov-staging · 2024-07-12T19:44:05Z

Bundle Report

Changes will decrease total bundle size by 30.18kB ⬇️

Bundle name	Size	Change
gazebo-staging-array-push	6.07MB	30.18kB ⬇️

codecov · 2024-07-12T19:44:36Z

Bundle Report

Changes will decrease total bundle size by 30.18kB ⬇️

Bundle name	Size	Change
gazebo-production-array-push	6.07MB	30.18kB ⬇️

codecov-releaser · 2024-07-12T19:51:35Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`759bc2b`	Fri, 12 Jul 2024 19:51:35 GMT	Expired	Expired
`16f1693`	Fri, 12 Jul 2024 21:06:40 GMT	Expired	Expired
`2b4070c`	Fri, 12 Jul 2024 21:18:16 GMT	Expired	Expired
`e044617`	Mon, 15 Jul 2024 14:10:16 GMT	Expired	Expired
`e3e6a50`	Mon, 15 Jul 2024 18:44:55 GMT	Cloud	Enterprise

nicholas-codecov

LGTM

spalmurray-codecov marked this pull request as ready for review July 12, 2024 21:09

spalmurray-codecov force-pushed the spalmurray/new-header-mycontextswitcher branch from 2b4070c to e044617 Compare July 15, 2024 14:00

spalmurray-codecov mentioned this pull request Jul 15, 2024

feat: New header polish #3017

Merged

spalmurray-codecov added 8 commits July 15, 2024 14:31

Adjust useMyContexts implementation to fix type inferences

6f27888

Copy MyContextSwitcher over to new header directory and convert to TS

ff39909

Add context switcher routing + little polish

0d4fd1d

Add selfhosted admin breadcrumb

a228e37

Fix test

cf5a1fc

Add Navigator tests

fcce809

Update header tests

c4d4c78

Run prettier

e3e6a50

spalmurray-codecov force-pushed the spalmurray/new-header-mycontextswitcher branch from e044617 to e3e6a50 Compare July 15, 2024 18:32

nicholas-codecov approved these changes Jul 16, 2024

View reviewed changes

spalmurray-codecov added this pull request to the merge queue Jul 16, 2024

Merged via the queue into main with commit 0421fe4 Jul 16, 2024
61 checks passed

spalmurray-codecov deleted the spalmurray/new-header-mycontextswitcher branch July 16, 2024 13:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement remaining Navigator functionality for new header #3012

feat: Implement remaining Navigator functionality for new header #3012

spalmurray-codecov commented Jul 12, 2024 •

edited

Loading

codecov-qa bot commented Jul 12, 2024 •

edited

Loading

codecov-staging bot commented Jul 12, 2024 •

edited by codecov-notifications bot

Loading

codecov-public-qa bot commented Jul 12, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading

codecov-staging bot commented Jul 12, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading

codecov-releaser commented Jul 12, 2024 •

edited

Loading

nicholas-codecov left a comment

feat: Implement remaining Navigator functionality for new header #3012

feat: Implement remaining Navigator functionality for new header #3012

Conversation

spalmurray-codecov commented Jul 12, 2024 • edited Loading

Screenshots

codecov-qa bot commented Jul 12, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Jul 12, 2024 • edited by codecov-notifications bot Loading

Codecov Report

codecov-public-qa bot commented Jul 12, 2024 • edited Loading

Codecov Report

codecov bot commented Jul 12, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Jul 12, 2024 • edited Loading

Bundle Report

codecov bot commented Jul 12, 2024 • edited Loading

Bundle Report

codecov-releaser commented Jul 12, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

nicholas-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Jul 12, 2024 •

edited

Loading

codecov-qa bot commented Jul 12, 2024 •

edited

Loading

codecov-staging bot commented Jul 12, 2024 •

edited by codecov-notifications bot

Loading

codecov-public-qa bot commented Jul 12, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading

codecov-staging bot commented Jul 12, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading

codecov-releaser commented Jul 12, 2024 •

edited

Loading