Skip to content

Commit

Permalink
Bug: Changelog didn't have the version (#324)
Browse files Browse the repository at this point in the history
I introduced a bug when refactoring the build pipleline, wherein there
wasn't a `./version` file anymore which stored the current version
number, such that it could be shared across build steps.

Therefore there was no version on the changelog! This fixes that by
creating a `version` taget for the Makefile and pushing that into a file
the changelog generator can use.

Work on #313
  • Loading branch information
markmandel authored and XAMPPRocky committed Jul 21, 2021
1 parent 362133e commit d7ae07d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
4 changes: 4 additions & 0 deletions build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ docker_in_docker := -v /var/run/docker.sock:/var/run/docker.sock
help:
@cat $(MAKEFILE_LIST) | docker run --rm -i xanders/make-help

# output the current build version
version:
@echo $(package_version)

# Run all tests
test: ensure-build-image
docker run --rm $(common_rust_args) \
Expand Down
7 changes: 7 additions & 0 deletions build/release/cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ steps:
- IMAGE_NAME=${_IMAGE_TAG}
- build
id: build
- name: us-docker.pkg.dev/$PROJECT_ID/ci/make-docker
dir: ./build
entrypoint: bash
args:
- '-c'
- 'make version > ../version'
id: output-version
- name: ferrarimarco/github-changelog-generator:1.15.2
id: changelog
entrypoint: sh
Expand Down

0 comments on commit d7ae07d

Please sign in to comment.