Bug: Changelog didn't have the version #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced a bug when refactoring the build pipleline, wherein there wasn't a `./version` file anymore which stored the current version number, such that it could be shared across build steps. Therefore there was no version on the changelog! This fixes that by creating a `version` taget for the Makefile and pushing that into a file the changelog generator can use. Work on #313
markmandel
added
kind/bug
|
Build Succeeded 🥳 Build Id: a4d42a57-63d6-46c4-8a05-e4a878332937 To build this version: |
XAMPPRocky
approved these changes
Jul 8, 2021
|
Build Succeeded 🥳 Build Id: e544f9b0-9d59-4eab-a9b7-0033ce06f167 To build this version: |
XAMPPRocky
pushed a commit
that referenced
this pull request
Jul 21, 2021
I introduced a bug when refactoring the build pipleline, wherein there wasn't a `./version` file anymore which stored the current version number, such that it could be shared across build steps. Therefore there was no version on the changelog! This fixes that by creating a `version` taget for the Makefile and pushing that into a file the changelog generator can use. Work on #313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug when refactoring the build pipleline, wherein there wasn't a
./versionfile anymore which stored the current version number, such that it could be shared across build steps.Therefore there was no version on the changelog! This fixes that by creating a
versiontaget for the Makefile and pushing that into a file the changelog generator can use.Work on #313
Proof that is works again: