Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Remove internal version endpoint into release/1.16.x #26077

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #25998 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


This PR removes the sys/internal/ui/version endpoint and its usage within the UI as part of the Reduced Disclosure work.

The UI keeps all of the functionality from #24262 but uses an authenticated call to the sys/seal endpoint once to get the version information.

  • Ent tests pass

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/VAULT-25018/remove-internal-version-endpoint/nationally-oriented-goldfish branch from 28a1530 to 8b54fc3 Compare March 21, 2024 16:14
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 21, 2024
@divyaac divyaac added this to the 1.16.0 milestone Mar 21, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@divyaac divyaac added the ui label Mar 21, 2024
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look correct!

@divyaac divyaac merged commit c93a923 into release/1.16.x Mar 21, 2024
77 of 79 checks passed
@divyaac divyaac deleted the backport/VAULT-25018/remove-internal-version-endpoint/nationally-oriented-goldfish branch March 21, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants