Remove internal version endpoint #25998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
divyaac
force-pushed
the
VAULT-25018/remove-internal-version-endpoint
branch
from
8b13ff5 to
d279175
Compare
divyaac
force-pushed
the
VAULT-25018/remove-internal-version-endpoint
branch
from
d279175 to
a9e1b2d
Compare
divyaac
force-pushed
the
VAULT-25018/remove-internal-version-endpoint
branch
from
0caaed9 to
a9e1b2d
Compare
…)" This reverts commit 550c99a.
|
Build Results: |
marcboudreau
approved these changes
Mar 20, 2024
version/version.go
Outdated
| @@ -23,6 +23,9 @@ func GetVersion() *VersionInfo { | |||
| if GitDescribe != "" { | |||
| ver = GitDescribe | |||
| } | |||
| if GitDescribe == "" && rel == "" && VersionPrerelease != "" { | |||
There was a problem hiding this comment.
This change shouldn't be reintroduced. When going through this file as part of introducing the sys/internal/ui/version path, I discovered that it was impossible for the condition on line 26 to be true. Because it requires VersionPrerelease to be not empty and rel to be empty. However, rel is initialized with the VersionPrerelease value above, so it would require rel to be a Schrödinger variable in order for the condition to be true.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
sys/internal/ui/versionendpoint and its usage within the UI as part of the Reduced Disclosure work.The UI keeps all of the functionality from #24262 but uses an authenticated call to the sys/seal endpoint once to get the version information.