UI/gh 26599/hide version if redacted #26614
Conversation
…sing service down
…version is properly redacted
github-actions
bot
added
the
hashicorp-contributed-pr
| // Fetch seal status with token to get version | ||
| const response = yield this.store.adapterFor('cluster').sealStatus(false); | ||
| // Fetch seal status to get version | ||
| const response = yield this.store.adapterFor('cluster').sealStatus(); |
There was a problem hiding this comment.
👉 this is the fix -- this is what ensures the UI hides the version by calling /seal-status/ unauthenticated.
@chelshaw i saw that this change was recent and intentionally added in #25998, so i wanted to check in with you about this as a solution. because we're just trying to grab the version property from the response, i wondered if calling the endpoint unauthenticated in this specific instance would be okay? it seems like if we needed more information that's only returned when the call is authenticated that we could just make a separate call then. what do you think?
|
CI Results: failed ❌ |
|
closing because we intentionally want to show the version if the user is authenticated. we only want to hide the version if the user in unauthenticated. |
No description provided.