Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Remove cargo fmt from the WASM Builder #3858

Closed
0x009922 opened this issue Sep 1, 2023 · 0 comments
Closed

[suggestion] Remove cargo fmt from the WASM Builder #3858

0x009922 opened this issue Sep 1, 2023 · 0 comments
Assignees
@Arjentix @Asem-Abdelhady @alexstroke1
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

0x009922 commented Sep 1, 2023

Description

I raised a discussion originally here: #3841 (comment)

I'm puzzled about the inclusion of cargo fmt in the build process. While it makes sense for wasm_builder to handle cargo check and cargo build due to specific rustc parameters, cargo fmt doesn't seem to need such configuration. So why is it part of the build? Is formatting not the developer's responsibility? Are there historical reasons for this design choice?

@ilchu suggested that @Arjentix might help with clarifying it.

Proposed solution

Remove cargo fmt from iroha_wasm_builder crate.
@0x009922 0x009922 added question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Sep 1, 2023
@0x009922 0x009922 mentioned this issue Sep 1, 2023
Merged
3 tasks
@mversic mversic removed the question Further information is requested label Oct 19, 2023
This was referenced Nov 29, 2023
Merged
Closed
Asem-Abdelhady added a commit that referenced this issue Dec 11, 2023
@Asem-Abdelhady
[fix] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env vari…
0fef278 
…able with true (#4096)

* [fix] #4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this issue Dec 11, 2023
@Asem-Abdelhady
[fix] hyperledger-iroha#4090 hyperledger-iroha#3858: Fix having to pa…
a7ed2c0 
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
@Asem-Abdelhady Asem-Abdelhady mentioned this issue Dec 11, 2023
Merged
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this issue Dec 12, 2023
@Asem-Abdelhady
[fix] hyperledger-iroha#4090 hyperledger-iroha#3858: Fix having to pa…
1f7e1b3 
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
mversic pushed a commit that referenced this issue Dec 12, 2023
@Asem-Abdelhady
[BACKPORT] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env…
b8d0e0e 
… variable with true (#4135)

Signed-off-by: Asem-Abdelhady <[email protected]>
@AlexStroke AlexStroke self-assigned this Jan 11, 2024
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this issue Jan 22, 2024
@Asem-Abdelhady
[fix] hyperledger-iroha#4090 hyperledger-iroha#3858: Fix having to pa…
eb2f1d3 
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

@Asem-Abdelhady Asem-Abdelhady

@alexstroke1 alexstroke1

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Arjentix @Asem-Abdelhady @0x009922 @mversic @AlexStroke @alexstroke1