-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true #4096
Merged
Asem-Abdelhady
merged 11 commits into
hyperledger-iroha:iroha2-dev
from
Asem-Abdelhady:iroha2-dev
Dec 11, 2023
Merged
[fix] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true #4096
Asem-Abdelhady
merged 11 commits into
hyperledger-iroha:iroha2-dev
from
Asem-Abdelhady:iroha2-dev
Dec 11, 2023
+22
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7141206152
💛 - Coveralls |
If we are gonna change that, we should at least rename the variable to have the inverted meaning, smth like |
mversic
reviewed
Nov 29, 2023
mversic
reviewed
Nov 29, 2023
d32f0c3
to
65a9b01
Compare
related #3858 |
we should remove formatting at build time and make sure in CI static analysis that we check formatting of |
ccdaf6c
to
60fb174
Compare
mversic
reviewed
Nov 30, 2023
57150ff
to
c70c203
Compare
mversic
reviewed
Dec 5, 2023
mversic
reviewed
Dec 5, 2023
mversic
reviewed
Dec 5, 2023
mversic
reviewed
Dec 7, 2023
BAStos525
previously approved these changes
Dec 8, 2023
mversic
previously approved these changes
Dec 8, 2023
DCNick3
reviewed
Dec 8, 2023
…KS env variable with true Signed-off-by: Asem-Abdelhady <[email protected]>
…ng PORFILE variable to be test Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
…atic CIs Signed-off-by: Asem-Abdelhady <[email protected]>
… checking from dev CI Signed-off-by: Asem-Abdelhady <[email protected]>
…from nix Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
6da47ea
to
e0f7913
Compare
mversic
approved these changes
Dec 8, 2023
DCNick3
approved these changes
Dec 8, 2023
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Dec 11, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <[email protected]> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <[email protected]> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <[email protected]> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <[email protected]> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <[email protected]> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <[email protected]> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <[email protected]> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <[email protected]> --------- Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Dec 12, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <[email protected]> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <[email protected]> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <[email protected]> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <[email protected]> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <[email protected]> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <[email protected]> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <[email protected]> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <[email protected]> --------- Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 22, 2024
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <[email protected]> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <[email protected]> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <[email protected]> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <[email protected]> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <[email protected]> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <[email protected]> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <[email protected]> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <[email protected]> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <[email protected]> --------- Signed-off-by: Asem-Abdelhady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the checking parts in build.rs files to check if the env is passed during the build. this should only build the WASM builder if the code snippet will be used and in our case it will not be because the env variable is not passed.