Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true #4096

Merged
merged 11 commits into from
Dec 11, 2023

Conversation

Asem-Abdelhady
Copy link
Contributor

@Asem-Abdelhady Asem-Abdelhady commented Nov 28, 2023

Description

Change the checking parts in build.rs files to check if the env is passed during the build. this should only build the WASM builder if the code snippet will be used and in our case it will not be because the env variable is not passed.

@coveralls
Copy link

coveralls commented Nov 28, 2023

Pull Request Test Coverage Report for Build 7141206152

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7017 unchanged lines in 130 files lost coverage.
  • Overall coverage decreased (-3.2%) to 56.28%

Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.2%
Covered Lines: 22995
Relevant Lines: 40858

💛 - Coveralls

@DCNick3
Copy link
Contributor

DCNick3 commented Nov 29, 2023

If we are gonna change that, we should at least rename the variable to have the inverted meaning, smth like IROHA_ENABLE_WASM_CHECKS

@DCNick3 DCNick3 self-assigned this Nov 29, 2023
@mversic
Copy link
Contributor

mversic commented Nov 29, 2023

related #3858

@mversic
Copy link
Contributor

mversic commented Nov 30, 2023

we should remove formatting at build time and make sure in CI static analysis that we check formatting of client/tests/integration/smartcontracts workspace and of default_executor

@Asem-Abdelhady Asem-Abdelhady changed the title [fix] #4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true [fix] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Nov 30, 2023
@Asem-Abdelhady Asem-Abdelhady force-pushed the iroha2-dev branch 2 times, most recently from 57150ff to c70c203 Compare December 4, 2023 07:37
BAStos525
BAStos525 previously approved these changes Dec 8, 2023
mversic
mversic previously approved these changes Dec 8, 2023
@mversic mversic requested review from DCNick3 and BAStos525 December 8, 2023 12:22
@Asem-Abdelhady Asem-Abdelhady merged commit 0fef278 into hyperledger-iroha:iroha2-dev Dec 11, 2023
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this pull request Dec 11, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this pull request Dec 12, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 22, 2024
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <[email protected]>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <[email protected]>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <[email protected]>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <[email protected]>

---------

Signed-off-by: Asem-Abdelhady <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants