Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: Deduplicate identical triggers #4419

Closed
Erigara opened this issue Apr 11, 2024 · 0 comments · Fixed by #4434
Closed

[refactor]: Deduplicate identical triggers #4419

Erigara opened this issue Apr 11, 2024 · 0 comments · Fixed by #4434
Assignees
@Erigara
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@Erigara
Copy link
Contributor

Erigara commented Apr 11, 2024

Atm iroha is trying to compile every trigger doesn't matter whatever it's already present in the state or not.

We can rely on wasm-time caching but we can do better by checking this on our side.
@Erigara Erigara added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Apr 11, 2024
@Erigara Erigara self-assigned this Apr 11, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 15, 2024
@Erigara
[refactor] hyperledger-iroha#4419: Deduplicate triggers with the same…
4c8bc1e 
… wasm code

Signed-off-by: Shanin Roman <[email protected]>
@Erigara Erigara mentioned this issue Apr 15, 2024
Merged
Erigara added a commit to Erigara/iroha that referenced this issue Apr 15, 2024
@Erigara
[refactor] hyperledger-iroha#4419: Deduplicate triggers with the same…
5276955 
… wasm code

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 19, 2024
@Erigara
[refactor] hyperledger-iroha#4419: Deduplicate triggers with the same…
76fd8ed 
… wasm code

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit to Erigara/iroha that referenced this issue Apr 19, 2024
@Erigara @mversic
[refactor] hyperledger-iroha#4419: Deduplicate triggers with the same…
e4f242d 
… wasm code

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 19, 2024
@Erigara
[refactor] hyperledger-iroha#4419: Deduplicate triggers with the same…
2c5eb6e 
… wasm code

Signed-off-by: Shanin Roman <[email protected]>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 19, 2024
@Erigara
[refactor] hyperledger-iroha#4419: Deduplicate triggers with the same…
abcfeb4 
… wasm code

Signed-off-by: Shanin Roman <[email protected]>
mversic pushed a commit that referenced this issue Apr 19, 2024
@Erigara
[refactor] #4419: Deduplicate triggers with the same wasm code (#4434)
8dc0cac 
Signed-off-by: Shanin Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] #4419: Deduplicate triggers with the same wasm code Erigara/iroha
1 participant
@Erigara