Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4419: Deduplicate triggers with the same wasm code #4434

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Apr 15, 2024

Description

If trigger was already compiled reuse it.

Linked issue

Closes #4419

Benefits

To demonstrate the difference 1000 identical triggers were registered.

Examination of changes was done on apple silicon machine:

# might need to: cargo install cargo-instruments
cd client
cargo instruments -t Allocations --example register_1000_triggers --profile profiling

Allocation before the change:
reg_trigger_before
before_Launch_register_1000_triggers_2024-04-15_18.01.00_EAAEDBCC.trace.zip

Allocations after the change:
reg_trigger_after
after_Launch_register_1000_triggers_2024-04-15_17.50.57_31C6FEB5.trace.zip

@Erigara Erigara added the Refactor Improvement to overall code quality label Apr 15, 2024
@Erigara Erigara self-assigned this Apr 15, 2024
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 15, 2024
@Erigara Erigara added the Optimization Something isn't working as well as it should label Apr 15, 2024
@nxsaken nxsaken changed the base branch from iroha2-dev to main April 16, 2024 08:35
@DCNick3 DCNick3 self-assigned this Apr 19, 2024
@VAmuzing VAmuzing self-assigned this Apr 19, 2024
@mversic mversic merged commit 8dc0cac into hyperledger-iroha:main Apr 19, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor]: Deduplicate identical triggers
4 participants