Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wsv_checker] #1294

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Conversation

kuvaldini
Copy link
Contributor

@kuvaldini kuvaldini commented Jul 26, 2021

[wsv_checker]

  • [wsv_checker] some static_assert-s to rocksdb_common
  • [wsv_checker] works with rocksdb through the only one iteration pass
  • [wsv_checker] works with postgres, can check_equals()

USAGE:

wsv_checker --help
wsv_checker --rocksdb_path /iroha/rocks.db --pg_opt "dbname=iroha_data host=localhost port=5432 user=postgres password=postgres"

@kuvaldini kuvaldini requested a review from a team July 26, 2021 10:37
@kuvaldini kuvaldini requested review from iceseer and kamilsa July 27, 2021 20:10
@kuvaldini kuvaldini marked this pull request as ready for review July 30, 2021 08:45
@kuvaldini kuvaldini force-pushed the wsv_checker branch 2 times, most recently from 59a93bd to 5936604 Compare July 30, 2021 14:08
@iceseer
Copy link
Contributor

iceseer commented Aug 2, 2021

You don't use rocksdb common functions, just direct calls to fields. It seems to be a problem to support such application structure. I can't modify DB structure without tool modification. How can we support consistency between iroha and tool db representations?

@kuvaldini
Copy link
Contributor Author

kuvaldini commented Aug 2, 2021

You don't use rocksdb common functions, just direct calls to fields. It seems to be a problem to support such application structure. I can't modify DB structure without tool modification. How can we support consistency between iroha and tool db representations?

That was done to make tool as simple as possible and read all in one pass.
To solve the issue, I'd not #undef RDB_*.

@kuvaldini kuvaldini requested a review from iceseer August 2, 2021 10:36
@iceseer
Copy link
Contributor

iceseer commented Aug 2, 2021

You don't use rocksdb common functions, just direct calls to fields. It seems to be a problem to support such application structure. I can't modify DB structure without tool modification. How can we support consistency between iroha and tool db representations?

That was done to make tool as simple as possible and read all in one pass.
To solve the issue, I'd not #undef RDB_*.

It means you will have the copy of a DB structure representation. So any fix cause to make it twice. Better to use functions family from rocksdb common. Tool is not performance critical, you don't need to compare everything in a single iteration, just check that both data is equal.

@kuvaldini kuvaldini force-pushed the wsv_checker branch 7 times, most recently from 5c6956c to cfc9c41 Compare August 5, 2021 16:59
@kuvaldini kuvaldini force-pushed the wsv_checker branch 2 times, most recently from 1a6f7dc to fb62785 Compare August 12, 2021 06:07
@kuvaldini kuvaldini force-pushed the wsv_checker branch 2 times, most recently from ef35f04 to ee7228c Compare August 19, 2021 12:42
@kuvaldini kuvaldini force-pushed the wsv_checker branch 2 times, most recently from efc13bb to 4d74f4e Compare August 21, 2021 11:54
/build all

Signed-off-by: kuvaldini <[email protected]>
/build all

Signed-off-by: kuvaldini <[email protected]>
…ove_peer_test, timeout 60s

/build all

Signed-off-by: kuvaldini <[email protected]>
@kuvaldini kuvaldini force-pushed the wsv_checker branch 2 times, most recently from 564221c to a69b808 Compare August 23, 2021 11:50
@kuvaldini kuvaldini merged commit d84decc into hyperledger-iroha:support/1.2.x Aug 23, 2021
@kuvaldini kuvaldini deleted the wsv_checker branch August 23, 2021 19:37
kuvaldini added a commit that referenced this pull request Aug 31, 2021
* [wsv_checker]
* [GHA] allow failing integration_fake_peer_examle_test, integration_remove_peer_test, timeout 60s

Signed-off-by: kuvaldini <[email protected]>
kuvaldini added a commit that referenced this pull request Aug 31, 2021
* [wsv_checker]
* [GHA] allow failing integration_fake_peer_examle_test, integration_remove_peer_test, timeout 60s

Signed-off-by: kuvaldini <[email protected]>
Signed-off-by: kuvaldini <[email protected]>
@kamilsa kamilsa mentioned this pull request Sep 3, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants