-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wsv_checker] #1294
[wsv_checker] #1294
Conversation
59a93bd
to
5936604
Compare
You don't use rocksdb common functions, just direct calls to fields. It seems to be a problem to support such application structure. I can't modify DB structure without tool modification. How can we support consistency between iroha and tool db representations? |
That was done to make tool as simple as possible and read all in one pass. |
It means you will have the copy of a DB structure representation. So any fix cause to make it twice. Better to use functions family from rocksdb common. Tool is not performance critical, you don't need to compare everything in a single iteration, just check that both data is equal. |
5c6956c
to
cfc9c41
Compare
1a6f7dc
to
fb62785
Compare
ef35f04
to
ee7228c
Compare
efc13bb
to
4d74f4e
Compare
/build all Signed-off-by: kuvaldini <[email protected]>
/build all Signed-off-by: kuvaldini <[email protected]>
…ove_peer_test, timeout 60s /build all Signed-off-by: kuvaldini <[email protected]>
564221c
to
a69b808
Compare
/build all
* [wsv_checker] * [GHA] allow failing integration_fake_peer_examle_test, integration_remove_peer_test, timeout 60s Signed-off-by: kuvaldini <[email protected]>
* [wsv_checker] * [GHA] allow failing integration_fake_peer_examle_test, integration_remove_peer_test, timeout 60s Signed-off-by: kuvaldini <[email protected]> Signed-off-by: kuvaldini <[email protected]>
[wsv_checker]
USAGE: