fix: Make iroha_smart_contract_utils log and dbg functions work outside of wasm
#4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
VAmuzing and
dima74
as code owners
DCNick3
changed the title
iroha_smart_contract_utils log and dbg functions work outside of wasmiroha_smart_contract_utils log and dbg functions work outside of wasm
Erigara
reviewed
Jun 13, 2024
Erigara
previously approved these changes
Jun 13, 2024
Erigara
approved these changes
Jun 14, 2024
Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
mversic
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
iroha_smart_contract_utils'sloganddbgfunctions to be used outside of wasm. This allows writing tests to be ran against the host target and to still use those wasm-specific functions.Both implementations just print the requested object to stderr.
As a drive-by, this also makes sure to run wasm tests from
iroha_smart_contract_utils, which was omitted in CI for some time.Linked issue
Fixes #4721
Benefits