[FAB-18132] Ch.Part.API: Remove ledger resources asynchronously #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Oct 20, 2020
yacovm
reviewed
Oct 20, 2020
|
I noticed this change introduced a data races along with a few other bad things. Working on fixing this up. |
stephyee
changed the title
stephyee
force-pushed
the
fab-18132
branch
2 times, most recently
from
192bda4 to
407e25f
Compare
tock-ibm
reviewed
Oct 26, 2020
wlahti
reviewed
Oct 27, 2020
stephyee
force-pushed
the
fab-18132
branch
3 times, most recently
from
0ecdd82 to
2d5ba70
Compare
tock-ibm
reviewed
Oct 28, 2020
stephyee
force-pushed
the
fab-18132
branch
2 times, most recently
from
b0ced9d to
2d6a499
Compare
tock-ibm
reviewed
Oct 29, 2020
stephyee
force-pushed
the
fab-18132
branch
3 times, most recently
from
ff8a247 to
521cd50
Compare
tock-ibm
reviewed
Oct 29, 2020
stephyee
force-pushed
the
fab-18132
branch
3 times, most recently
from
844330d to
59908f3
Compare
stephyee
force-pushed
the
fab-18132
branch
2 times, most recently
from
0ccd4ed to
b1e3ea5
Compare
tock-ibm
reviewed
Nov 1, 2020
tock-ibm
reviewed
Nov 1, 2020
tock-ibm
reviewed
Nov 3, 2020
|
@tock-ibm will do, first I need to clean up some flakiness with the int test. |
tock-ibm
previously approved these changes
Nov 5, 2020
|
Looks good to me. |
wlahti
suggested changes
Nov 6, 2020
Signed-off-by: Tiffany Harris <[email protected]>
wlahti
approved these changes
Nov 6, 2020
|
Looks good to me. |
yacovm
reviewed
Nov 6, 2020
| r.pendingRemoval[channelID] = true | ||
|
|
||
| go func() { | ||
| if err := r.ledgerFactory.Remove(channelID); err != nil { |
There was a problem hiding this comment.
can't we make this simpler?
err := r.ledgerFactory.Remove(channelID)
r.lock.Lock()
defer r.lock.Unlock()
if err != nil {
....
}
There was a problem hiding this comment.
very much so yes - I'll handle in a follow-up.
yacovm
reviewed
Nov 6, 2020
| if removalStatus { | ||
| return types.ErrChannelPendingRemoval | ||
| } else { | ||
| return types.ErrChannelRemovalFailure |
There was a problem hiding this comment.
Maybe #2027 (comment) this should only apply to the Joining a channel that experienced a removal failure.
yacovm
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Removes ledger resources in asynchronously when channel participation APIs remove is called.
Related issues
FAB-18132