Add OpenTelemetry tracing with grpc interceptors #2954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
add_otel
branch
7 times, most recently
from
3b3244b to
ee0ac99
Compare
denyeart
reviewed
Sep 29, 2021
| @@ -19,7 +19,7 @@ require ( | |||
| github.com/frankban/quicktest v1.11.3 // indirect | |||
| github.com/fsouza/go-dockerclient v1.7.0 | |||
| github.com/go-kit/kit v0.9.0 | |||
| github.com/golang/protobuf v1.3.3 | |||
| github.com/golang/protobuf v1.5.2 | |||
There was a problem hiding this comment.
We have been stuck at protobuf v1.3 and older grpc due to etcd issues. See background in https://jira.hyperledger.org/browse/FAB-18363 and #2185.
@guoger has been looking at etcd update in #2707 and may be able to fill in the details.
atoulme
force-pushed
the
add_otel
branch
3 times, most recently
from
4e358d0 to
b903cf3
Compare
Signed-off-by: Antoine Toulme <[email protected]>
atoulme
force-pushed
the
add_otel
branch
17 times, most recently
from
aa87322 to
b18f2ed
Compare
Signed-off-by: Antoine Toulme <[email protected]>
|
Closing owing to the long inactivity - please re-open and rebase if it's still needed |
|
I cannot reopen this PR, I will open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds OpenTelemetry tracing by adding interceptors on all gRPC communications.
Related issues
This is tied to https://github.com/hyperledger/fabric-rfcs/blob/main/text/0000-opentelemetry-tracing.md