Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Users page: button should be "delete" not remove #2813

Closed
russorat opened this issue Feb 14, 2018 · 3 comments
Closed

All Users page: button should be "delete" not remove #2813

russorat opened this issue Feb 14, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@russorat
Copy link
Contributor

russorat commented Feb 14, 2018

The button on the far right of the screenshot should say Delete instead of Remove.

image

@alexpaxton alexpaxton self-assigned this Mar 19, 2018
alexpaxton added a commit that referenced this issue Mar 19, 2018
@alexpaxton alexpaxton mentioned this issue Mar 19, 2018
3 tasks
bthesorceror pushed a commit that referenced this issue Mar 21, 2018
@russorat russorat added this to the 1.4.3 milestone Mar 27, 2018
@russorat
Copy link
Contributor Author

image

@russorat russorat reopened this Mar 27, 2018
@alexpaxton
Copy link
Contributor

I was able to reproduce the issue, looks like the removeUser action is being called with an undefined payload.

I looked at AllUsersTableRow.js where the action is called from and I was able to fix by doing this:

  // const wrappedDelete = _.curry(onDelete, user)
  const wrappedDelete = () => {
    onDelete(user)
  }

I looked up what _.curry does and I'm not sure it is working as intended

@russorat
Copy link
Contributor Author

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants