Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Delete Button in All Users Admin Table #3073

Merged
merged 5 commits into from
Mar 28, 2018
Merged

Fix Delete Button in All Users Admin Table #3073

merged 5 commits into from
Mar 28, 2018

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 27, 2018 •
edited
Loading

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #2813

The Problem

  • Deleting a user from the All Users table throws an error

The Solution

  • Used a plain JS arrow function instead of lodash's .curry
  • Made current org table delete UX consistent with all users table

@alexpaxton alexpaxton requested a review from 121watts March 28, 2018 19:46
@russorat russorat added this to the 1.4.3 milestone Mar 28, 2018
jaredscheib
jaredscheib reviewed Mar 28, 2018
View reviewed changes
ui/src/admin/components/chronograf/UsersTableRow.js
onDelete(user)
}

const removeWarning = 'Remove this user\nfrom Current Org?'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd put this copy in a constant file but it's super minor

jaredscheib
jaredscheib approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@jaredscheib jaredscheib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@alexpaxton alexpaxton merged commit 290a6ab into master Mar 28, 2018
@alexpaxton alexpaxton deleted the bugfix/delete-chrono-user branch March 28, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredscheib jaredscheib jaredscheib approved these changes

@121watts 121watts Awaiting requested review from 121watts

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@alexpaxton @jaredscheib @russorat