Add playback rewrite backend and plugin systems #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
playback/jellyfin/src/main/kotlin/queue/item/BaseItemDtoUserQueueEntry.kt
Fixed
Show fixed
Hide fixed
| import org.jellyfin.playback.core.plugin.PlaybackPlugin | ||
| import org.jellyfin.playback.core.plugin.PlayerService | ||
|
|
||
| class PlaybackManagerBuilder() { |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed.
| import org.jellyfin.playback.core.PlaybackManager | ||
| import org.jellyfin.playback.core.PlayerState | ||
|
|
||
| abstract class PlayerService { |
Check warning
Code scanning / detekt
An abstract class is unnecessary. May be refactored to an interface or to a concrete class.
| class PlaybackManager internal constructor( | ||
| val backend: PlayerBackend, | ||
| private val services: MutableList<PlayerService>, | ||
| private val mediaStreamResolvers: List<MediaStreamResolver>, |
Check warning
Code scanning / detekt
Private member is unused and should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There we go, the second big PR for the playback rewrite! I've spent some time rewriting the core of the rewrite to design an architecture that I felt satisfied with the past few weeks. This PR contains a part of it. Everything related to video is removed and some unstable parts are missing too.
(Not all individual commits build because some of them are missing PlaybackManager)
Changes
Add PlaybackManager
Manages all the playback stuff, should technically support multi-instance but we'll use it single instance for now. Stores the active backend in the PlaybackRepository (name will probably change, implementation is mostly missing because most of it's functionality is video related).
Add MediaStreamResolver (currently unused, reserved for a future PR)
Returns MediaStream's (most implementation is missing because it was still incomplete/non-functional. Only stream URL for now)
Add PlayerState
It contains the current state of playback and contains functions to manipulate the state. This is one of the most important parts of the playback module.
Add PlayerBackend & BasePlayerBackend
Binds to the actual player (ExoPlayer). Emits events that are converted to the PlayerState instance. Plugins should normally not access the backend directly.
Add plugins
A plugin provides various parts to the playback code: backends, services and media stream resolvers. Most plugins will only provide services that work with PlayerState.
Queue changes
Converted to service, some metadata updates
Next PR in another year!
Issues
Part of #1057