Add ExoPlayer backend to playback rewrite #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
nielsvanvelzen
changed the title
crobibero
approved these changes
Jan 17, 2023
DavidFair
reviewed
Jan 17, 2023
| .also { player -> player.addListener(PlayerListener()) } | ||
| } | ||
|
|
||
| inner class PlayerListener : Player.Listener { |
There was a problem hiding this comment.
More of a nit, is it worth pulling derivative classe(s) out into a dedicated file(s) early?
The existing Exoplayer/VLC code organically grew and turned into a mixture of boilerplate and implementation, hence I'm wondering if it's worth separating before we add to it?
There was a problem hiding this comment.
Right now the ExoPlayer implementation is small enough that it doesn't matter. When the class grows it will likely get split into multiple files. I also believe large files aren't a huge problem, the fact that it isn't related to the file it's in is the problem. In the current player code we have pretty much everything in one file, the "ExoPlayerBackend" only contains the binding to ExoPlayer.
nielsvanvelzen
force-pushed
the
playback-exoplayer
branch
from
7c6de03 to
774dacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There we go, the third big PR for the playback rewrite! Well actually not that big but it adds an important part. This PR is a follow up on #2401 where I didn't include the ExoPlayer backend intentionally.
Changes
Issues
Part of #1057