feat(nimbus): Approval and rejection flow #12090
Conversation
yashikakhurana
requested review from
jaredlockhart and
freshstrangemusic
as code owners
|
Blocked on #11932 |
|
Okay! This is already looking great 🎉 🎉 🎉 Couple things I notice from local testing:
Look at what the V5 serializer does here on save: We need to do these same things. |
@jaredlockhart rejection message not showing up is related to changelog issue and that's why it's not included. I have added all the sync issues which was happening on the serializer to the forms, it should be called immediately now. I will investigate the changelog issue and made a point to implement this rejection message functionality with it. |
| # Allocate bucket range if needed | ||
| if experiment.has_filter(NimbusExperiment.Filters.SHOULD_ALLOCATE_BUCKETS): | ||
| experiment.allocate_bucket_range() | ||
|
|
||
| if experiment.should_call_preview_task: | ||
| nimbus_synchronize_preview_experiments_in_kinto.apply_async(countdown=5) | ||
|
|
||
| if experiment.should_call_push_task: | ||
| collection = experiment.kinto_collection | ||
| nimbus_check_kinto_push_queue_by_collection.apply_async( | ||
| countdown=5, args=[collection] | ||
| ) |
There was a problem hiding this comment.
Oh so yes this mirrors the way we did it in the serializer where it's a single save method handling all possible state changes. But I think we can simplify this even more since we have specific state transition forms below, so rather than checking whether we're in some state transition and whether we should do any of these, we can just hard code them into the save methods of the appropriate forms below, and then we don't need to check which state transition we're in.
Because
This commit
Fixes #12072
Note: This currently does not show the rejection reason-which I will add in the separate PR
Approval flow
Untitled.mov
Rejection flow
Screen.Recording.2025-01-22.at.3.38.00.PM.mov
Timeout message
