test(nimbus): Test cases

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/detail.html

@@ -22,24 +22,17 @@
       </div>
     {% endfor %}
   {% endif %}
-  <!-- Experiment Container -->
-  <div id="experiment-container">
-    <div id="experiment-timeline">
-      {% include "nimbus_experiments/timeline.html" %}
+  <div id="launch-controls">
+    {% if experiment.is_draft %}
+      {% include "nimbus_experiments/launch_controls.html" %}
 
-    </div>
-    <div id="launch-controls">
-      {% if experiment.is_draft %}
-        {% include "nimbus_experiments/launch_controls.html" %}
-
-      {% elif experiment.is_preview %}
-        {% include "nimbus_experiments/launch_with_preview_controls.html" %}
+    {% elif experiment.is_preview %}
+      {% include "nimbus_experiments/launch_with_preview_controls.html" %}
 
-      {% elif experiment.is_review %}
-        {% include "nimbus_experiments/review_controls.html" %}
+    {% elif experiment.is_review %}
+      {% include "nimbus_experiments/review_controls.html" %}
 
-      {% endif %}
-    </div>
+    {% endif %}
   </div>
   <!-- Takeaways Card -->
   {% include "nimbus_experiments/takeaways_card.html" %}
@@ -383,4 +376,5 @@ <h6>
   {{ block.super }}
   <script src="{% static 'nimbus_ui_new/setup_selectpicker.bundle.js' %}"></script>
   <script src="{% static 'nimbus_ui_new/control.bundle.js' %}"></script>
+  <script>htmx.logAll();</script>
 {% endblock %}

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/experiment_base.html

@@ -22,6 +22,9 @@ <h4 class="mb-0">{{ experiment.name }}</h4>
         </p>
       {% endif %}
     </div>
-     {% include "nimbus_experiments/timeline.html" %}
+    <div id="experiment-timeline">
+      {% include "nimbus_experiments/timeline.html" %}
+
+    </div>
   </div>
 {% endblock %}

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/launch_controls.html

@@ -10,7 +10,7 @@
     <form method="post"
           action="{% url 'nimbus-new-launch-to-preview' slug=experiment.slug %}"
           hx-post="{% url 'nimbus-new-launch-to-preview' slug=experiment.slug %}"
-          hx-target="#experiment-container"
+          hx-target="#launch-controls, #experiment-timeline"
           hx-swap="innerHTML">
       {% csrf_token %}
       <button type="submit"
@@ -20,7 +20,7 @@
     <form method="post"
           action="{% url 'nimbus-new-launch-without-preview' slug=experiment.slug %}"
           hx-post="{% url 'nimbus-new-launch-without-preview' slug=experiment.slug %}"
-          hx-target="#experiment-container"
+          hx-target="#launch-controls, #experiment-timeline"
           hx-swap="outerHTML">
       {% csrf_token %}
       <button type="submit"

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/launch_with_preview_controls.html

@@ -16,7 +16,7 @@
   <form method="post"
         action="{% url 'nimbus-new-launch-preview-to-review' slug=experiment.slug %}"
         hx-post="{% url 'nimbus-new-launch-preview-to-review' slug=experiment.slug %}"
-        hx-target="#launch-controls"
+        hx-target="#launch-controls, #experiment-timeline"
         hx-swap="outerHTML"
         id="preview-controls-form">
     {% csrf_token %}
@@ -46,13 +46,13 @@
               class="btn btn-primary mx-3"
               id="request-launch-button"
               hx-post="{% url 'nimbus-new-launch-preview-to-review' slug=experiment.slug %}"
-              hx-target="#experiment-container"
+              hx-target="#launch-controls, #experiment-timeline"
               hx-swap="innerHTML"
               disabled>Request Launch</button>
       <button type="button"
               class="btn btn-secondary"
               hx-post="{% url 'nimbus-new-launch-preview-to-draft' slug=experiment.slug %}"
-              hx-target="#experiment-container"
+              hx-target="#launch-controls, #experiment-timeline"
               hx-swap="innerHTML">Go Back to Draft</button>
     </div>
   </form>

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/launch_without_preview_controls.html

@@ -3,8 +3,8 @@
   <form method="post"
         action="{% url 'nimbus-new-launch-to-preview' slug=experiment.slug %}"
         hx-post="{% url 'nimbus-new-launch-to-preview' slug=experiment.slug %}"
-        hx-target="#experiment-container"
-        hx-swap="innerHTML">
+        hx-target="#launch-controls, #experiment-timeline"
+        hx-swap="outerHTML">
     {% csrf_token %}
     <span class="text-danger">We recommend previewing before launch</span>
     <button type="submit"
@@ -15,8 +15,8 @@
 <form method="post"
       action="{% url 'nimbus-new-launch-preview-to-review' slug=experiment.slug %}"
       hx-post="{% url 'nimbus-new-launch-preview-to-review' slug=experiment.slug %}"
-      hx-target="#experiment-container"
-      hx-swap="innerHTML">
+      hx-target="#launch-controls, #experiment-timeline"
+      hx-swap="outerHTML">
   {% csrf_token %}
   <div class="form-check">
     <input type="checkbox"
@@ -41,6 +41,6 @@
   <button type="button"
           class="btn btn-secondary"
           hx-post="{% url 'nimbus-new-launch-preview-to-draft' slug=experiment.slug %}"
-          hx-target="#experiment-container"
+          hx-target="#launch-controls, #experiment-timeline"
           hx-swap="innerHTML">Cancel</button>
 </form>

experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/review_controls.html

@@ -2,8 +2,8 @@
 <form method="post"
       action="{% url 'nimbus-new-cancel-review' slug=experiment.slug %}"
       hx-post="{% url 'nimbus-new-cancel-review' slug=experiment.slug %}"
-      hx-target="#experiment-container"
-      hx-swap="innerHTML">
+      hx-target="#launch-controls, #experiment-timeline"
+      hx-swap="outerHTML">
   {% csrf_token %}
   <div class="alert alert-warning">
     <p>The experiment is currently under review. If you wish to cancel the review, click the button below:</p>

experimenter/experimenter/nimbus_ui_new/views.py

@@ -272,6 +272,7 @@ class UnsubscribeView(
     form_class = UnsubscribeForm
     template_name = "nimbus_experiments/subscribers_list.html"
 
+
 class TimelineAndControlsMixin:
     """
     Mixin to handle rendering of timeline and controls for a given experiment.
@@ -295,10 +296,8 @@ def render_response_with_timeline_and_controls(self, experiment, controls_templa
 
         return HttpResponse(
             f"""
-            <div id="experiment-container">
                 <div id="experiment-timeline">{timeline_html}</div>
                 <div id="launch-controls">{controls_html}</div>
-            </div>
             """
         )