Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook Snapshotting to the default Notebook isn't working #4469

Closed
3 of 5 tasks
charlesh88 opened this issue Nov 16, 2021 · 2 comments · Fixed by #4475
Closed
3 of 5 tasks

Notebook Snapshotting to the default Notebook isn't working #4469

charlesh88 opened this issue Nov 16, 2021 · 2 comments · Fixed by #4475
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Milestone
Target: 1.8.3

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Nov 16, 2021 •
edited by nikhilmandlik
Loading

Summary

Snapshotting to the default Notebook doesn't do anything, and fails without a console error. I was able to successfully save a Snapshot to the Snapshots holder.

Expected vs Current Behavior

Should work as expected.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Create a new Notebook. Add an entry, and verify that that Notebook is designated as the default.

image

  1. Navigate to a data view such as a plot. Use the Snapshot menu button, and verify that the expected default Notebook appears as a menu option. Select that option.

image

  1. Note that a Notification message indicates that the Snapshot was saved:

image

  1. Nav back to the default Notebook. Observe: no entry with a Snapshot has been added.

Environment

  • Open MCT Version: 1.8.1
  • Deployment Type: /stable and /latest
  • OS: Mac
  • Browser: Chrome

Additional Information
@unlikelyzero unlikelyzero added the bug:regression It used to work. Now it doesn't :( label Nov 16, 2021
nikhilmandlik added a commit that referenced this issue Nov 17, 2021
@nikhilmandlik
Notebook Snapshotting to the default Notebook isn't working #4469
537d72d
@nikhilmandlik nikhilmandlik mentioned this issue Nov 17, 2021
Merged
8 tasks
@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 5, 2022
nikhilmandlik added a commit that referenced this issue Jan 6, 2022
@nikhilmandlik
Notebook Snapshotting to the default Notebook isn't working #4469
f16c01f
nikhilmandlik added a commit that referenced this issue Jan 6, 2022
@nikhilmandlik
Notebook Snapshotting to the default Notebook isn't working #4469
b96212b
@shefalijoshi
Copy link
Contributor

Please verify: #2918 and #4526 after this is fixed.

nikhilmandlik added a commit that referenced this issue Jan 6, 2022
@nikhilmandlik
Notebook Snapshotting to the default Notebook isn't working #4469
b626786
@shefalijoshi shefalijoshi mentioned this issue Jan 6, 2022
Closed
akhenry pushed a commit that referenced this issue Jan 7, 2022
@nikhilmandlik
Notebook Snapshotting to the default Notebook isn't working (#4475)
a8da0d5 
* Notebook Snapshotting to the default Notebook isn't working #4469
@akhenry akhenry closed this as completed Jan 7, 2022
@unlikelyzero
Copy link
Contributor

Verified Fixed

unlikelyzero pushed a commit that referenced this issue Jan 20, 2022
@shefalijoshi @davetsay
@nikhilmandlik @michaelrogers
release 1.8.3 - master (#4752)
dcaad40 
* Fix object creation (#4675)

* Save the object before adding it to the parent so that transaction committing works properly
* Fix object creation - composition policy changes

* use relative path (#4683)

* Notebook Snapshotting to the default Notebook isn't working (#4475)

* Notebook Snapshotting to the default Notebook isn't working #4469

* Check for ref when trying to get the style receiver. (#4687)

Also ensure that the property being displayed in Properties is actually a part of the domainObject.

* Mct 4555 rebased v3 (#4689)

* Preserve the previousFocusedImage for subscription updates, bound change for local and fixed time

* Only preserve previous focused image if paused

* Forcibly reset imageContainer size to prevent aspect ratio distortion

* Remove unneccesary mixin invocation

* Use image history instead of imagehistory size for watcher. Revert other changes

* Added check if last image index is selected

* isPaused instead of paused

Co-authored-by: Michael Rogers <[email protected]>

* Snapshot notice link not navigating as expected #4194 (#4686)

* Fix Link Action to accept the right input for validation (#4696)

* Remove snapshot from release version (#4721)

Co-authored-by: David Tsay <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Michael Rogers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:blocker type:bug
Projects
None yet
Milestone
Target: 1.8.3
Development

Successfully merging a pull request may close this issue.

Notebook Snapshotting to the default Notebook isn't working nasa/openmct
5 participants
@charlesh88 @nikhilmandlik @akhenry @shefalijoshi @unlikelyzero