Notebook Snapshotting to the default Notebook isn't working #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/1.8.3 #4475 +/- ##
================================================
Coverage ? 56.38%
================================================
Files ? 718
Lines ? 22794
Branches ? 1656
================================================
Hits ? 12852
Misses ? 9535
Partials ? 407 Continue to review full report at Codecov.
|
akhenry
requested changes
Dec 6, 2021
charlesh88
reviewed
Dec 22, 2021
|
@nikhilmandlik This looks good. Could you please change the base to |
nikhilmandlik
force-pushed
the
notebook-entry-issue
branch
from
fdecc37 to
d05d5ad
Compare
nikhilmandlik
force-pushed
the
notebook-entry-issue
branch
from
d05d5ad to
ca3f262
Compare
nikhilmandlik
force-pushed
the
notebook-entry-issue
branch
from
ca3f262 to
9923c8c
Compare
unlikelyzero
requested review from
charlesh88 and
akhenry
and removed request for
akhenry
akhenry
approved these changes
Jan 7, 2022
Reviewer Checklist
|
16 tasks
unlikelyzero
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Fix object creation (#4675) * Save the object before adding it to the parent so that transaction committing works properly * Fix object creation - composition policy changes * use relative path (#4683) * Notebook Snapshotting to the default Notebook isn't working (#4475) * Notebook Snapshotting to the default Notebook isn't working #4469 * Check for ref when trying to get the style receiver. (#4687) Also ensure that the property being displayed in Properties is actually a part of the domainObject. * Mct 4555 rebased v3 (#4689) * Preserve the previousFocusedImage for subscription updates, bound change for local and fixed time * Only preserve previous focused image if paused * Forcibly reset imageContainer size to prevent aspect ratio distortion * Remove unneccesary mixin invocation * Use image history instead of imagehistory size for watcher. Revert other changes * Added check if last image index is selected * isPaused instead of paused Co-authored-by: Michael Rogers <[email protected]> * Snapshot notice link not navigating as expected #4194 (#4686) * Fix Link Action to accept the right input for validation (#4696) * Remove snapshot from release version (#4721) Co-authored-by: David Tsay <[email protected]> Co-authored-by: Nikhil <[email protected]> Co-authored-by: Michael Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
resolves: #4469
All Submissions:
Author Checklist