Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate potential memory leak with image manipulation #180

Closed
dbarrosop opened this issue Oct 5, 2023 · 1 comment
Closed

investigate potential memory leak with image manipulation #180

dbarrosop opened this issue Oct 5, 2023 · 1 comment
Assignees
@dbarrosop

Comments

@dbarrosop
Copy link
Member

It only manifests with projects using image manipulation. With image manipulation:

image

without image manipulation (and way higher usage than the project above):

image
@dbarrosop dbarrosop self-assigned this Oct 5, 2023
@dbarrosop dbarrosop mentioned this issue Jan 18, 2024
Merged
@dbarrosop
Copy link
Member Author

Did some research and it isn't technically a memory leak but, in any case, PR #196 should reduce the amount of memory used.

dbarrosop added a commit that referenced this issue Jan 26, 2024
@dbarrosop
feat: replace custom C code with govips (#196)
c5c23f1 
We initially wrote our own C code because our benchmarking showed govips
used too much memory but now it seems to be the opposite. Their library
is also better than our custom code and it should fix #194 and #180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbarrosop dbarrosop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbarrosop