Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image orientation metadata lost when transformations applied #194

Closed
wildsurfer opened this issue Jan 17, 2024 · 3 comments · Fixed by #196
Closed

Image orientation metadata lost when transformations applied #194

wildsurfer opened this issue Jan 17, 2024 · 3 comments · Fixed by #196

Comments

@wildsurfer
Copy link

When I'm trying to upload an image that has orientation metadata in EXIF it has a different orientation when I apply any transformations or not.

When I don't apply any transformations it looks as it should (proper orientation taken from EXIF).
Example: https://local.storage.nhost.run/v1/files/967213bb-3f6a-4e31-911d-f7e529867865

But when I apply any transformation orientation is wrong.
Example: https://local.storage.nhost.run/v1/files/967213bb-3f6a-4e31-911d-f7e529867865?q=95&w=375

Here is an example image to play with:
IMG_3423

@wildsurfer
Copy link
Author

And here is how it looks in Nhost dashboard:
Screenshot 2024-01-17 at 14 05 14

@dbarrosop
Copy link
Member

Thanks for reporting and for providing a sample image to test with. This issue should be addressed in #196 once ready.

dbarrosop added a commit that referenced this issue Jan 26, 2024
We initially wrote our own C code because our benchmarking showed govips
used too much memory but now it seems to be the opposite. Their library
is also better than our custom code and it should fix #194 and #180
@dbarrosop
Copy link
Member

0.6.0 should fix this issue, feel free to upgrade and let us know otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants