Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nexus): Use kona-bin-utils #1099

Open
wants to merge 1 commit into
base: cl/separate-bin-utils
Choose a base branch
from
Open

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Feb 24, 2025

Overview

Uses the kona-bin-utils crate for kona-nexus. The init_tracing_subscriber function in kona-bin-utils has been altered to accept an optional EnvFilter. The other logic, for "is-tty," should be handled internally by the FMT subscriber already.

@clabby clabby added A-binaries Area: binaries K-chore Kind: chore labels Feb 24, 2025
@clabby clabby self-assigned this Feb 24, 2025
@clabby
Copy link
Collaborator Author

clabby commented Feb 24, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.6%. Comparing base (2cdece0) to head (ad97462).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
bin/bin-utils/src/tracing.rs 61.5% 5 Missing ⚠️
bin/nexus/src/main.rs 0.0% 2 Missing ⚠️
bin/nexus/src/telemetry.rs 0.0% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-binaries Area: binaries K-chore Kind: chore
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant