Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bin-utils): Add prometheus server initializer #1100

Open
wants to merge 2 commits into
base: cl/node-bin
Choose a base branch
from
Open

feat(bin-utils): Add prometheus server initializer #1100

wants to merge 2 commits into from

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Feb 24, 2025

Overview

Adds a shared prometheus server initializer to kona-bin-utils, taken from kona-nexus.

@clabby clabby requested a review from refcell as a code owner February 24, 2025 21:24
@clabby clabby added the A-binaries Area: binaries label Feb 24, 2025
@clabby clabby requested a review from emhane as a code owner February 24, 2025 21:24
@clabby clabby added the K-chore Kind: chore label Feb 24, 2025
@clabby clabby self-assigned this Feb 24, 2025
@clabby
Copy link
Collaborator Author

clabby commented Feb 24, 2025 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

This was referenced Feb 24, 2025
Open
Open
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.6%. Comparing base (ad97462) to head (f0de166).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
bin/bin-utils/src/prometheus.rs 0.0% 9 Missing ⚠️
bin/nexus/src/telemetry.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/prometheus-bin-util branch from f0f50ca to 42eb0ce Compare February 24, 2025 21:35
@clabby clabby mentioned this pull request Feb 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell Awaiting requested review from refcell refcell is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@clabby clabby

Labels
A-binaries Area: binaries K-chore Kind: chore
Projects
Project Tracking
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clabby