Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds): ds list #2066

Open
wants to merge 1 commit into
base: 02-21-fix_job-runner_fix_build_pack_in_job-runner_dockerfile
Choose a base branch
from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Feb 21, 2025

Fixes RVT-4584

Changes

Copy link

cloudflare-workers-and-pages bot commented Feb 21, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: f777315
Status:🚫  Build failed.

View logs

Copy link

linear bot commented Feb 21, 2025

Copy link
Contributor Author

MasterPtato commented Feb 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies server listing functionality in the Rivet game server management system, focusing on tag matching and workflow tracking improvements.

  • Changed tag matching logic in ds_server_list_for_env to check if all input tags match server tags, rather than vice versa, fixing potential filtering issues
  • Added WorkflowIdKey struct in packages/edge/services/ds/src/keys/server.rs to properly track workflow IDs for server instances
  • Optimized ds_server_get operation to use FDB for parallel workflow ID fetching with buffer_unordered(1024)
  • Removed debug logging statements from workflow metrics collection in fdb_sqlite_nats/mod.rs for cleaner output
  • Added Debug trait to ServerKeyData struct in packages/edge/services/ds/src/keys/env.rs for improved debugging capabilities

10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@MasterPtato MasterPtato force-pushed the 02-21-fix_job-runner_fix_build_pack_in_job-runner_dockerfile branch from d167037 to 39b675e Compare February 22, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant