-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ds): ds list #2066
Open
MasterPtato
wants to merge
1
commit into
02-21-fix_job-runner_fix_build_pack_in_job-runner_dockerfile
Choose a base branch
from
02-21-fix_ds_ds_list
base: 02-21-fix_job-runner_fix_build_pack_in_job-runner_dockerfile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(ds): ds list #2066
MasterPtato
wants to merge
1
commit into
02-21-fix_job-runner_fix_build_pack_in_job-runner_dockerfile
from
02-21-fix_ds_ds_list
+105
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2025
This was referenced Feb 21, 2025
This was referenced Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies server listing functionality in the Rivet game server management system, focusing on tag matching and workflow tracking improvements.
- Changed tag matching logic in
ds_server_list_for_env
to check if all input tags match server tags, rather than vice versa, fixing potential filtering issues - Added
WorkflowIdKey
struct inpackages/edge/services/ds/src/keys/server.rs
to properly track workflow IDs for server instances - Optimized
ds_server_get
operation to use FDB for parallel workflow ID fetching withbuffer_unordered(1024)
- Removed debug logging statements from workflow metrics collection in
fdb_sqlite_nats/mod.rs
for cleaner output - Added Debug trait to
ServerKeyData
struct inpackages/edge/services/ds/src/keys/env.rs
for improved debugging capabilities
10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
d167037
to
39b675e
Compare
a7a1b58
to
f777315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVT-4584
Changes