Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js-utils): correctly handle esbuild with import-statement not matching node stdlib #2067

Conversation

NathanFlurry
Copy link
Member

Changes

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request focuses on fixing ESBuild import handling in the JavaScript utilities, specifically addressing Node.js standard library import statement mismatches.

  • Added .github/workflows/autofix.ci.yml to automatically fix code formatting using Biome in frontend, site, and SDK directories
  • Added .github/workflows/fe-pull-request.yml to run code quality checks on frontend-related changes
  • Added .github/workflows/rust.yaml to handle Rust-specific CI checks including formatting and dependency validation
  • Added .github/workflows/release.yaml to manage versioned releases with binary builds and Docker image creation
  • Added .github/workflows/pkg-pr-new.yaml to automate package publishing for approved pull requests

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member Author

NathanFlurry commented Feb 22, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 22, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 22, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1428171
Status:⚡️  Build in progress...

View logs

@MasterPtato MasterPtato force-pushed the 02-21-fix_fdb_conflict_ranges branch from 652c945 to d498e79 Compare February 22, 2025 02:54
@NathanFlurry NathanFlurry changed the base branch from 02-21-fix_fdb_conflict_ranges to graphite-base/2067 February 22, 2025 12:25
@NathanFlurry NathanFlurry changed the base branch from graphite-base/2067 to 02-21-fix_fdb_conflict_ranges February 22, 2025 12:26
@NathanFlurry NathanFlurry changed the base branch from 02-21-fix_fdb_conflict_ranges to graphite-base/2067 February 22, 2025 12:33
@NathanFlurry NathanFlurry force-pushed the 02-21-fix_js-utils_correctly_handle_esbuild_with_import-statement_not_matching_node_stdlib branch from 52a882d to 1428171 Compare February 22, 2025 12:33
@NathanFlurry NathanFlurry changed the base branch from graphite-base/2067 to main February 22, 2025 12:33
Copy link
Contributor

graphite-app bot commented Feb 22, 2025

Merge activity

  • Feb 22, 7:34 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 22, 7:35 AM EST: CI is running for this PR on a draft PR: #2072
  • Feb 22, 7:36 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2072.

graphite-app bot pushed a commit that referenced this pull request Feb 22, 2025
…ching node stdlib (#2067)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Feb 22, 2025
@graphite-app graphite-app bot deleted the 02-21-fix_js-utils_correctly_handle_esbuild_with_import-statement_not_matching_node_stdlib branch February 22, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant