improvement: sorting workspace members with same name by frequency #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
May 9, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
2 times, most recently
from
c19e31b to
b764a3a
Compare
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
May 9, 2024
filipwiech
reviewed
May 9, 2024
metals/src/main/scala/scala/meta/internal/metals/ReferenceProvider.scala
Outdated
Show resolved
Hide resolved
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
May 10, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
b764a3a to
bf42d0d
Compare
kasiaMarek
reviewed
May 10, 2024
mtags-interfaces/src/main/java/scala/meta/pc/PresentationCompiler.java
Outdated
Show resolved
Hide resolved
tests/cross/src/test/scala/tests/pc/CompletionContextSuite.scala
Outdated
Show resolved
Hide resolved
mtags/src/main/scala-2/scala/meta/internal/pc/completions/Completions.scala
Outdated
Show resolved
Hide resolved
tgodzik
reviewed
May 13, 2024
mtags-interfaces/src/main/java/scala/meta/pc/ReferenceCountProvider.java
Outdated
Show resolved
Hide resolved
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
May 19, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
bf42d0d to
3e1f2f3
Compare
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
May 21, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
2d23ffe to
e67d5d3
Compare
tgodzik
requested changes
May 27, 2024
mtags-interfaces/src/main/java/scala/meta/pc/CompletionItemPriority.java
Outdated
Show resolved
Hide resolved
mtags/src/main/scala-3/scala/meta/internal/pc/ScalaPresentationCompiler.scala
Outdated
Show resolved
Hide resolved
mtags/src/main/scala-2/scala/meta/internal/pc/completions/Completions.scala
Outdated
Show resolved
Hide resolved
| val futureCompletionResult: List[String] = | ||
| List("Future - scala.concurrent", "Future - java.util.concurrent") | ||
|
|
||
| checkItems( |
There was a problem hiding this comment.
Why not use check it would still be visible which one is first.
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
Jun 26, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
e67d5d3 to
361b2fc
Compare
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
361b2fc to
3c047b4
Compare
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
Jul 4, 2024
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
Jul 4, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
3c047b4 to
71f7d34
Compare
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
Jul 4, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
71f7d34 to
6d42fa1
Compare
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
Jul 4, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
6d42fa1 to
ed3a875
Compare
Temurlock
added a commit
to Temurlock/metals
that referenced
this pull request
Jul 4, 2024
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
ed3a875 to
4467bc7
Compare
tgodzik
requested changes
Jul 5, 2024
metals/src/main/scala/scala/meta/internal/metals/ReferenceProvider.scala
Outdated
Show resolved
Hide resolved
Temurlock
force-pushed
the
sorting_workspace_members
branch
from
4467bc7 to
e5fea0c
Compare
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Aug 12, 2024
scalameta/metals#6620 - only test added, it already worked in `scala3` pc scalameta/metals#6625 scalameta/metals#6393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by: scalameta/metals-feature-requests#254 (comment)
Added ranking by frequency for workspace symbols with the same name.
It useful when project has multiple objects with same name (like Future (scala, java, twitter) or Clock (java, cats, zio))
It uses ReferenceProvider to count files where workspace member could have been referenced
False positive result from bloom filter is counted as reference in file to keep sorting fast (if we wanted to make it precise we should read semanticdb of matching paths which is expensive)