fix: don't suggest completions for param names in definition #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
completions-for-param-defs
branch
from
235bdc6 to
a1dc9dd
Compare
tgodzik
reviewed
Jul 25, 2024
| @@ -527,6 +527,9 @@ class Completions( | |||
| case Literal(Constant(null)) :: tl => | |||
| advancedCompletions(tl, pos, completionPos) | |||
|
|
|||
| // def foo(a@@) | |||
| case (vd: ValDef) :: (d : DefDef) :: _ if d.paramss.flatten.exists(_.span.contains(vd.span)) => | |||
| (KeywordsCompletions.contribute(path, completionPos), true) | |||
There was a problem hiding this comment.
Should we just allow implicit and using keywords?
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Aug 12, 2024
scalameta/metals#6620 - only test added, it already worked in `scala3` pc scalameta/metals#6625 scalameta/metals#6393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #6623